linux-kernel - Re: [PATCH] usb: fix unterminated usn_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070913035407.GN8183@outflux.net>
Date:	Wed, 12 Sep 2007 20:54:07 -0700
From:	Kees Cook <kees@...ntu.com>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	linux-kernel@...r.kernel.org, Ben Collins <bcollins@...ntu.com>
Subject: Re: [PATCH] usb: fix unterminated usn_device_id lists

Hi,

On Wed, Sep 12, 2007 at 09:15:07PM -0400, Jeff Garzik wrote:
>> +	{ 0, },
>
> FWIW I (and several drivers) tend to prefer the more clean version,
>
> 	{ },
>
> or even
>
> 	{ },	/* terminate list */

Ah, yes.  I see that now in some of the other drivers.  Should I re-send
this patch (and/or the other PCI patches)?

Thanks,

-Kees

-- 
Kees Cook
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/