linux-kernel - Re: Credentials test patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.0.999.0709131304510.16478@woody.linux-foundation.org>
Date:	Thu, 13 Sep 2007 13:09:53 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	David Howells <dhowells@...hat.com>
cc:	viro@....linux.org.uk, hch@...radead.org,
	linux-kernel@...r.kernel.org
Subject: Re: Credentials test patch



On Thu, 13 Sep 2007, David Howells wrote:
> 
> Here's a patch that implements a very basic set of COW credentials. 

That "current_cred" thing is really too ugly to live.

Why is it trying to make it look like a variable? That will just confuse 
people, and/or make them think it's a cheap thing rather than some complex 
function call.

Also, why does the "__current_cred()" function have those illogical and 
insane "#ifdef CONFIG_KEYS" things in it, when it cannot be used/work 
sanely without it (and when the header file does a

	+#ifndef CONFIG_KEYS
	+#define __current_cred()       ({ current->cred; })
	+#else
	..

anyway?)

IOW, this patch should be taken out and shot, for apparently actively 
trying to obfuscate what the heck is going on.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/