linux-kernel - Re: [PATCH] wake up from a serial port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070913232119.GA32307@kroah.com>
Date:	Thu, 13 Sep 2007 16:21:19 -0700
From:	Greg KH <greg@...ah.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Guennadi Liakhovetski <g.liakhovetski@....de>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Russell King <rmk@....linux.org.uk>,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	Kay Sievers <kay.sievers@...y.org>
Subject: Re: [PATCH] wake up from a serial port

On Wed, Sep 12, 2007 at 03:36:10PM -0700, Andrew Morton wrote:
> On Wed, 12 Sep 2007 20:50:10 +0200 (CEST)
> Guennadi Liakhovetski <g.liakhovetski@....de> wrote:
> 
> > Enable wakeup from serial ports, make it run-time configurable over sysfs, 
> > e.g.,
> > 
> > echo enabled > /sys/devices/platform/serial8250.0/tty/ttyS0/power/wakeup
> > 
> > Requires
> > 
> > # CONFIG_SYSFS_DEPRECATED is not set
> > 
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@....de>
> > 
> > ---
> > 
> > Following suggestions from Alan and Russell moved the may_wake_up checks 
> > to serial_core.c. This time actually tested - it does even work. Could 
> > someone, please, verify, that put_device after device_find_child is 
> > correct?
> 
> Seems right to me, from reading device_find_child() and its associated
> documentation.

Yes, that is correct.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/