linux-kernel - Re: [PATCH] Blackfin arch: add some missing syscall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070913080701.GB27871@linux-sh.org>
Date:	Thu, 13 Sep 2007 17:07:01 +0900
From:	Paul Mundt <lethal@...ux-sh.org>
To:	Bryan Wu <bryan.wu@...log.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	uclinux-dist-devel@...ckfin.uclinux.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH] Blackfin arch: add some missing syscall

On Thu, Sep 13, 2007 at 03:56:43PM +0800, Bryan Wu wrote:
> @@ -352,9 +353,54 @@
>  #define __NR_shmdt		340
>  #define __NR_shmget		341
>  
> -#define __NR_syscall		342
> +#define __NR_splice		342
> +#define __NR_sync_file_range	343
> +#define __NR_tee		344
> +#define __NR_vmsplice		345
> +
> +#define __NR_epoll_pwait	346
> +#define __NR_utimensat		347
> +#define __NR_signalfd		348
> +#define __NR_timerfd		349
> +#define __NR_eventfd		350
> +#define __NR_pread64		351
> +#define __NR_pwrite64		352
> +#define __NR_fadvise64		353
> +
> +#define __NR_syscall		354
>  #define NR_syscalls		__NR_syscall
>  
Err, why did you change __NR_syscall? This is going to break the ABI for
anything using it, which is generally bad form.

You also missed sys_fallocate(), another reason to be using git, rather
than some silly subversion tree ;-)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/