[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8bd0f97a0709130145u474ab017ocf58b004c5d69dc0@mail.gmail.com>
Date: Thu, 13 Sep 2007 04:45:13 -0400
From: "Mike Frysinger" <vapier.adi@...il.com>
To: "Andrew Morton" <akpm@...ux-foundation.org>
Cc: bryan.wu@...log.com, "David Woodhouse" <dwmw2@...radead.org>,
"Thomas Gleixner" <tglx@...utronix.de>,
linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Blackfin BF54x NAND Flash Controller driver
On 9/13/07, Andrew Morton <akpm@...ux-foundation.org> wrote:
> On Mon, 03 Sep 2007 15:25:23 +0800 Bryan Wu <bryan.wu@...log.com> wrote:
> > This is the driver for latest Blackfin BF54x nand flash controller
> >
> > - use nand_chip and mtd_info common nand driver interface
> > - provide both PIO and dma operation
> > - compiled with ezkit bf548 configuration
> > - use hardware 1-bit ECC
> > - tested with YAFFS2 and can mount YAFFS2 filesystem as rootfs
> >
> > ...
> >
> > +int hardware_ecc = 0;
>
> scripts/checkpatch.pl, please.
that isnt static so checkpatch.pl wouldnt have caught it ... it should
be static though of course and then checkpatch.pl would have thrown a
static init 0 warning :)
-mike
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists