linux-kernel - Re: sysfs: spit a warning to users when they try to create a duplicate sysfs file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070914140621.77054e9d@gondolin.boeblingen.de.ibm.com>
Date:	Fri, 14 Sep 2007 14:06:21 +0200
From:	Cornelia Huck <cornelia.huck@...ibm.com>
To:	Greg KH <greg@...ah.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: sysfs: spit a warning to users when they try to create a
 duplicate sysfs file

On Thu, 13 Sep 2007 16:41:18 -0700,
Greg KH <greg@...ah.com> wrote:


>  int sysfs_add_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd)
>  {
> -	if (sysfs_find_dirent(acxt->parent_sd, sd->s_name))
> +	if (sysfs_find_dirent(acxt->parent_sd, sd->s_name)) {
> +		printk(KERN_WARNING, "sysfs: duplicate filename '%s' "

Stray ',' here ------------------->^
> +		       "can not be created\n", sd->s_name);
> +		WARN_ON(1);
>  		return -EEXIST;
> +	}
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/