linux-kernel - Re: [patch 1/4] Introduce pathput

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070914163611.GA30469@infradead.org>
Date:	Fri, 14 Sep 2007 17:36:11 +0100
From:	Christoph Hellwig <hch@...radead.org>
To:	Christoph Hellwig <hch@...radead.org>,
	Andreas Gruenbacher <agruen@...e.de>,
	linux-kernel@...r.kernel.org, John Johansen <jjohansen@...e.de>,
	Jan Blunck <jblunck@...e.de>, Erez Zadok <ezk@...sunysb.edu>,
	Josef 'Jeff' Sipek <jsipek@...sunysb.edu>
Subject: Re: [patch 1/4] Introduce pathput

On Wed, Aug 29, 2007 at 08:07:10PM +0100, Christoph Hellwig wrote:
> > * Switch from path_release_on_umount(nd) to pathput_on_umount(&nd->path).
> > 
> > * Rename dput_path() to pathput_conditional().
> 
> The introduction of pathput is fine we me.  The removal of path_release
> doesn't make much sense.  We have tons of invocations of exactly that
> patter, and having keeping path_release for that makes a lot of sense.

After some private discussion on this I think I was overruled, so feel
free to keep that change.  Al also suggested to rename the things
to path_get/path_put which makes sense.

Any chance you could respin the series with the review comments addressed
so that there is a chance to get it into 2.6.24?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/