linux-kernel - Re: [PATCH 1/2] Trace code and documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070914175027.GA3642@uranus.ravnborg.org>
Date:	Fri, 14 Sep 2007 19:50:27 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	David Wilder <dwilder@...ibm.com>
Cc:	linux-kernel@...r.kernel.org,
	SystemTAP <systemtap@...rces.redhat.com>,
	akpm@...ux-foundation.org
Subject: Re: [PATCH 1/2] Trace code and documentation

Hi David.

A random comment to the code.
Several of the struct file_operations are not declared static as
they should be.

Btw. it looks good from a coding style point-of-view.

About the name what about ktrace??

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/