linux-kernel - Re: sysfs: spit a warning to users when they try to create a duplicate sysfs file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46EBD3BA.9020306@s5r6.in-berlin.de>
Date:	Sat, 15 Sep 2007 14:44:42 +0200
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Greg KH <greg@...ah.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: sysfs: spit a warning to users when they try to create a duplicate
 sysfs file

Greg KH wrote:
> We want to let people know when we create a duplicate sysfs file, as
> they need to fix up their code.
> 
> 
> Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
> 
> ---
>  fs/sysfs/dir.c |    6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> --- a/fs/sysfs/dir.c
> +++ b/fs/sysfs/dir.c
> @@ -428,8 +428,12 @@ void sysfs_addrm_start(struct sysfs_addr
>   */
>  int sysfs_add_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd)
>  {
> -	if (sysfs_find_dirent(acxt->parent_sd, sd->s_name))
> +	if (sysfs_find_dirent(acxt->parent_sd, sd->s_name)) {
> +		printk(KERN_WARNING, "sysfs: duplicate filename '%s' "
> +		       "can not be created\n", sd->s_name);
> +		WARN_ON(1);
>  		return -EEXIST;
> +	}
>  
>  	sd->s_parent = sysfs_get(acxt->parent_sd);
>  

As a side story:

I've got code which has checks for device_create_file != 0 but keeps
quiet if it got -EEXIST.  I rewrote it now so that it does not rely on
the driver core to skip over already existing files.  Doing this
revealed a group of old refcounting bugs. :-)  Thanks,
-- 
Stefan Richter
-=====-=-=== =--= -====
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/