linux-kernel - Re: [PATCH]: x86_64: Remove unnecessary cast in prefetch()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 16 Sep 2007 01:16:18 +0400
From:	Serge Belyshev <belyshev@...ni.sinp.msu.ru>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Andi Kleen <ak@...e.de>, patches@...-64.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH]: x86_64: Remove unnecessary cast in prefetch()

Andi Kleen <andi@...stfloor.org> writes:

...
>> to make kernel work with GCC 4.3 and above.  (Also note that gcc 4.2 already
>> smart enough to break that code, but kernel is just lucky currently).
>
> How would it break the code exactly?  It more sounded like an optimization
> to me. Would it generate incorrect code without it?

See http://gcc.gnu.org/PR33294 for testcase which fails if compiled with gcc 4.2
and above.  Yes, incorrect code can be generated without the patch as demonstrated by
testcase, but i didn't analyze why kernel appears to work with 4.2 currently.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/