[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20070915013000.GA25414@localhost.localdomain>
Date: Sat, 15 Sep 2007 11:30:00 +1000
From: David Gibson <dwg@....ibm.com>
To: Josh Boyer <jwboyer@...ux.vnet.ibm.com>
Cc: Andrew Morton <akpm@...l.org>, linuxppc-dev@...abs.org,
Atsushi Nemoto <anemo@....ocn.ne.jp>,
linux-kernel@...r.kernel.org, rtc-linux@...glegroups.com
Subject: Re: rtc-ds1742.c should use resource_size_t for base address
On Fri, Sep 14, 2007 at 12:20:37PM -0500, Josh Boyer wrote:
> On Fri, 14 Sep 2007 15:54:27 +1000
> David Gibson <david@...son.dropbear.id.au> wrote:
>
> > Currently the rtc driver, rtc-ds1742.c uses an unsigned long to store
> > the base mmio address of the NVRAM/RTC. This breaks on systems like
> > PowerPC 440, which is a 32-bit core with 36-bit physical addresses: IO
> > on the system, including the RTC, is typically above the 4GB point,
> > and cannot fit into an unsigned long.
> >
> > This patch fixes the problem by replacing the unsigned long with a
> > resource_size_t. Tested on Ebony (PPC440) (with additional patches to
> > instantiate the ds1742 platform device appropriately).
>
> Where would those additional patches be? :)
Coming, they still need polish...
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists