linux-kernel - Re: [PATCH]PCI:disable resource decode in PCI BAR detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <46EDBE39.4090704@shaw.ca>
Date:	Sun, 16 Sep 2007 17:37:29 -0600
From:	Robert Hancock <hancockr@...w.ca>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	Ivan Kokshaysky <ink@...assic.park.msu.ru>,
	Greg KH <gregkh@...e.de>, Matthew Wilcox <matthew@....cx>,
	Shaohua Li <shaohua.li@...el.com>,
	lkml <linux-kernel@...r.kernel.org>,
	linux-pci <linux-pci@...ey.karlin.mff.cuni.cz>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH]PCI:disable resource decode in PCI BAR detection

Benjamin Herrenschmidt wrote:
> On Thu, 2007-09-13 at 21:32 -0600, Robert Hancock wrote:
>> If we do encounter other devices that choke on having the BAR
>> disabled 
>> during probing then we can add additional quirk logic, but we haven't 
>> run into anything like that yet.
> 
> Well... if the device needs to be accessed to service an interrupt then
> you do have a problem. For example... the PIC :-)
> 
> Problem is.. it's not practical nor really feasible generally to have
> IRQs off on all CPUs during PCI probing neither... Unless we define that
> the initial boot time probing is "special", and the first pass that
> actually probes devices (and doesn't muck around with the sysfs
> hierarchy etc...) can be run in a special context with all interrupt
> servicing disabled on the PIC, though that will require some arch
> support.
> 
> Ben.

We would already have this problem, though. If it causes problems to 
disable decode on the BAR because we try to access it in interrupt 
context, we would already have problems because we move the thing to 
0xFFFFFFFF during probing anyway..

-- 
Robert Hancock      Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@...pamshaw.ca
Home Page: http://www.roberthancock.com/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/