linux-kernel - Re: [PATCH] x86: constify stacktrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <46EE5DDF.76E4.0078.0@novell.com>
Date:	Mon, 17 Sep 2007 09:58:39 +0100
From:	"Jan Beulich" <jbeulich@...ell.com>
To:	"Andrew Morton" <akpm@...ux-foundation.org>
Cc:	"Andi Kleen" <ak@...e.de>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: constify stacktrace_ops

>>> Andrew Morton <akpm@...ux-foundation.org> 16.09.07 12:18 >>>
>On Mon, 10 Sep 2007 14:02:17 +0100 "Jan Beulich" <jbeulich@...ell.com> wrote:
>
>> .. as they're never written to.
>
>arch/i386/kernel/traps.c: In function 'dump_trace':
>arch/i386/kernel/traps.c:197: warning: initialization discards qualifiers from pointer target type
>
>Due to
>
>                struct ops_and_data oad = { .ops = ops, .data = data };
>
>messy to fix.

Not really - 'struct ops_and_data' can simply have its 'ops' member also be
declared 'struct stacktrace_ops *'. I actually have the patch this way here,
but since I generally submit patches against Linus' tree, I had to rip out
these hunks, since the structure gets added with the unwinder patch.

Jan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/