| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <Pine.LNX.4.64.0709171947130.15413@blonde.wat.veritas.com> Date: Mon, 17 Sep 2007 19:57:00 +0100 (BST) From: Hugh Dickins <hugh@...itas.com> To: Andrew Morton <akpm@...ux-foundation.org> cc: Balbir Singh <balbir@...ux.vnet.ibm.com>, linux-kernel@...r.kernel.org, linux-mm@...ck.org Subject: [PATCH mm] fix swapoff breakage; however... rc4-mm1's memory-controller-memory-accounting-v7.patch broke swapoff: it extended unuse_pte_range's boolean "found" return code to allow an error return too; but ended up returning found (1) as an error. Replace that by success (0) before it gets to the upper level. Signed-off-by: Hugh Dickins <hugh@...itas.com> --- More fundamentally, it looks like any container brought over its limit in unuse_pte will abort swapoff: that doesn't doesn't seem "contained" to me. Maybe unuse_pte should just let containers go over their limits without error? Or swap should be counted along with RSS? Needs reconsideration. mm/swapfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- 2.6.23-rc4-mm1/mm/swapfile.c 2007-09-07 13:09:42.000000000 +0100 +++ linux/mm/swapfile.c 2007-09-17 15:14:47.000000000 +0100 @@ -642,7 +642,7 @@ static int unuse_mm(struct mm_struct *mm break; } up_read(&mm->mmap_sem); - return ret; + return (ret < 0)? ret: 0; } /* - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists