linux-kernel - Re: [PATCH 1/2] gpio_keys: add gpio_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d120d5000709180859r48f0d123h339884dcf481f001@mail.gmail.com>
Date:	Tue, 18 Sep 2007 11:59:28 -0400
From:	"Dmitry Torokhov" <dmitry.torokhov@...il.com>
To:	"Anti Sullin" <anti.sullin@...ecdesign.ee>
Cc:	LKML <linux-kernel@...r.kernel.org>, akpm@...ux-foundation.org,
	david-b@...bell.net
Subject: Re: [PATCH 1/2] gpio_keys: add gpio_to_irq return code check

Hi Anti,

On 9/18/07, Anti Sullin <anti.sullin@...ecdesign.ee> wrote:
> As David Brownell pointed out when reviewing my suspend patch to
> gpio_keys, the original gpio_keys driver does not check gpio_to_irq
> return code.
>
...
> -               set_irq_type(irq, IRQ_TYPE_EDGE_BOTH);
> -               error = request_irq(irq, gpio_keys_isr, IRQF_SAMPLE_RANDOM,
> -                                    button->desc ? button->desc : "gpio_keys",
> -                                    pdev);
> +               if (irq < 0)

What would be the value of error variable (that we use as a return value) here?

> +                       goto fail;
> +

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/