lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070918164154.GA14594@in.ibm.com>
Date:	Tue, 18 Sep 2007 22:11:54 +0530
From:	Ananth N Mavinakayanahalli <ananth@...ibm.com>
To:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	Andi Kleen <andi@...stfloor.org>, prasanna@...ibm.com,
	anil.s.keshavamurthy@...el.com, davem@...emloft.net
Subject: Re: [patch 08/11] Text Edit Lock - kprobes i386

On Mon, Sep 17, 2007 at 02:40:39PM -0400, Mathieu Desnoyers wrote:
> Make kprobes use text_set instead of text_poke.
> 
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>

Tested-by: Ananth N Mavinakayanahalli <ananth@...ibm.com>

> CC: Andi Kleen <andi@...stfloor.org>
> CC: prasanna@...ibm.com
> CC: ananth@...ibm.com
> CC: anil.s.keshavamurthy@...el.com
> CC: davem@...emloft.net
> ---
>  arch/i386/kernel/kprobes.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> Index: linux-2.6-lttng/arch/i386/kernel/kprobes.c
> ===================================================================
> --- linux-2.6-lttng.orig/arch/i386/kernel/kprobes.c	2007-09-11 15:47:50.000000000 -0400
> +++ linux-2.6-lttng/arch/i386/kernel/kprobes.c	2007-09-11 15:48:52.000000000 -0400
> @@ -177,12 +177,13 @@ int __kprobes arch_prepare_kprobe(struct
> 
>  void __kprobes arch_arm_kprobe(struct kprobe *p)
>  {
> -	text_poke(p->addr, ((unsigned char []){BREAKPOINT_INSTRUCTION}), 1);
> +	text_poke(p->addr, INIT_ARRAY(unsigned char, BREAKPOINT_INSTRUCTION, 1),
> +			1);
>  }
> 
>  void __kprobes arch_disarm_kprobe(struct kprobe *p)
>  {
> -	text_poke(p->addr, &p->opcode, 1);
> +	text_poke(p->addr, INIT_ARRAY(unsigned char, p->opcode, 1), 1);
>  }
> 
>  void __kprobes arch_remove_kprobe(struct kprobe *p)
> 
> -- 
> Mathieu Desnoyers
> Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
> OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ