linux-kernel - Re: [PATCH 0/2] unify DMA_..BIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46EF69B1.8020801@goop.org>
Date:	Mon, 17 Sep 2007 23:01:21 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Muli Ben-Yehuda <muli@...ibm.com>
CC:	Borislav Petkov <bbpetkov@...oo.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] unify DMA_..BIT_MASK definitions: v1

Muli Ben-Yehuda wrote:
>> +#define DMA_64BIT_MASK	DMA_BIT_MASK(64)
>>     
>
> This one does not do what you mean. You need an explicit mask or a
> ~0ULL here.

Yeah, I was just about to comment on it.  Its possible the compiler
might decide to shift by x%64 = 0.

    J

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/