linux-kernel - Re: 2.6.23-rc6-mm1 panic (memory controller issue ?)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0709191154230.2241@schroedinger.engr.sgi.com>
Date:	Wed, 19 Sep 2007 11:54:50 -0700 (PDT)
From:	Christoph Lameter <clameter@....com>
To:	Balbir Singh <balbir@...ux.vnet.ibm.com>
cc:	Badari Pulavarty <pbadari@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>, balbir@...ibm.com,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: 2.6.23-rc6-mm1 panic (memory controller issue ?)

On Wed, 19 Sep 2007, Balbir Singh wrote:

> Yes, the whole code is very interesting. From add_to_page_cache()
> we call radix_tree_preload with __GFP_HIGHMEM cleared, but
> from __add_to_swap_cache(), we don't make any changes to the
> gfp_mask. radix_tree_preload() calls kmem_cache_alloc() and in slub
> there is a check
> 
>         BUG_ON(flags & GFP_SLAB_BUG_MASK);
> 
> So, I guess all our allocations should check against __GFP_DMA and
> __GFP_HIGHMEM. I'll review the code, test it and send a fix.

You need to use the proper mask from include/linux/gfp.h. Masking 
individual bits will create problems when we create new bits.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/