linux-kernel - Re: [PATCH 4/4] sysfs: make suicidal nodes just do it directly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46F240DF.7050303@gmail.com>
Date:	Thu, 20 Sep 2007 18:43:59 +0900
From:	Tejun Heo <htejun@...il.com>
To:	Cornelia Huck <cornelia.huck@...ibm.com>
CC:	ebiederm@...ssion.com, greg@...ah.com, stern@...land.harvard.edu,
	kay.sievers@...y.org, linux-kernel@...r.kernel.org,
	rusty@...tcorp.com.au
Subject: Re: [PATCH 4/4] sysfs: make suicidal nodes just do it directly

Cornelia Huck wrote:
> On Thu, 20 Sep 2007 16:26:15 +0900,
> Tejun Heo <htejun@...il.com> wrote:
> 
>> Sysfs now allows direct suicide.  Make suicidial sysfs nodes to use
>> it and remove now unncessary callback mechanism.
>>
>> Signed-off-by: Tejun Heo <htejun@...il.com>
>> ---
>>  drivers/base/core.c         |   33 ----------------------
>>  drivers/s390/cio/ccwgroup.c |   25 +++-------------
>>  drivers/scsi/scsi_sysfs.c   |   13 +--------
>>  fs/sysfs/file.c             |   63 -------------------------------------------
>>  include/linux/device.h      |    6 ----
>>  include/linux/sysfs.h       |    9 ------
>>  6 files changed, 6 insertions(+), 143 deletions(-)
>>
> 
> Just browsing through this (I'll review and do some tests later), but
> you missed drivers/s390/cio/device.c::ccw_device_remove_disconnected().
> 
> Following (not event compile tested) patch (which is basically a revert
> of 59a8a6e227cf0bc42e5be741ebfea97c222ab9ef) should take care of it.
> 
> Signed-off-by: Cornelia Huck <cornelia.huck@...ibm.com>

Thanks for spotting this.  After converting ccwgroup, I thought that was
it for s390.

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/