[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <46F1F2CE.7020300@pobox.com>
Date: Thu, 20 Sep 2007 00:10:54 -0400
From: Jeff Garzik <jgarzik@...ox.com>
To: "Maciej W. Rozycki" <macro@...ux-mips.org>
CC: Ralf Baechle <ralf@...ux-mips.org>,
Andrew Morton <akpm@...ux-foundation.org>,
netdev@...r.kernel.org, linux-mips@...ux-mips.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...
Maciej W. Rozycki wrote:
> Remove typedefs, volatiles and convert kmalloc()/memset() pairs to
> kcalloc(). Also reformat the surrounding clutter.
>
> Signed-off-by: Maciej W. Rozycki <macro@...ux-mips.org>
> ---
> On Thu, 13 Sep 2007, Jeff Garzik wrote:
>
>> Net driver patches should apply on top of netdev-2.6.git#upstream, which is
>> where changes to net drivers are queued for the next release.
>
> I can see Andrew has done some changes to the patch and applied it
> anyway, but here's a version I generated against your tree. Please feel
> free to choose either.
>
> You may be pleased (or less so) to hear that the version of sb1250-mac.c
> in your tree does not even build (because of
> 42d53d6be113f974d8152979c88e1061b953bd12) and the patch below does not
> address it. I ran out of time in the evening, but I will send you a fix
> shortly. To be honest I think even with bulk changes it may be worth
> checking whether they do not break stuff. ;-)
hrm. I cannot get this to apply on top of linux-2.6.git,
netdev-2.6.git#upstream (prior to net-2.6.24 rebase) or
netdev-2.6.git#upstream (after net-2.6.24 rebase)
ACK the changes
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists