linux-kernel - Re: [PATCH 02/03] CM-x270: ITE 8152 PCI bridge support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070921130119.GB20538@flint.arm.linux.org.uk>
Date:	Fri, 21 Sep 2007 14:01:20 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Guennadi Liakhovetski <gl@...-ac.de>
Cc:	Mike Rapoport <mike@...pulab.co.il>,
	ARM Linux <linux-arm-kernel@...ts.arm.linux.org.uk>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 02/03] CM-x270: ITE 8152 PCI bridge support

On Fri, Sep 21, 2007 at 12:42:55PM +0200, Guennadi Liakhovetski wrote:
> On Thu, 20 Sep 2007, Mike Rapoport wrote:
> 
> > This patch provides driver for ITE 8152 PCI bridge.
> > 
> > Signed-off-by: Mike Rapoport <mike@...pulab.co.il>
> > 
> >  arch/arm/common/Makefile          |    1 +
> >  arch/arm/common/it8152.c          |  387 +++++++++++++++++++++++++++++++++++++
> 
> Shouldn't it go to drivers/pci and define a platform driver? it8152 is not 
> an ARM specific controller.

drivers/pci is currently only used for the PCI bus infrastructure.  The
setup of host bridges is very platform dependent.

Also note that you should *avoid* DMA bounce wherever possible.
The code is broken as designed.  Ensure that the DMA mask is set
appropriately, and then moan elsewhere if things don't work.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/