linux-kernel - Re: [patch 5/5] VFS: allow filesystem to override mknod capability checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070921143338.GA14577@infradead.org>
Date:	Fri, 21 Sep 2007 15:33:38 +0100
From:	Christoph Hellwig <hch@...radead.org>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	hch@...radead.org, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [patch 5/5] VFS: allow filesystem to override mknod capability checks

On Fri, Sep 21, 2007 at 03:18:33PM +0200, Miklos Szeredi wrote:
> > That's something that shouldn't be solved in the filesystem, but rather
> > through exact semantics of unprivilegued mounts.  Given that an
> > unprivilegued implies ignoring the device files we can easily allow
> > users to create them, because they're nothing special anymore.
> 
> Exacly.  And we already have an API for that: mknod(2).  It would be
> quite stupid to introduce _another_ API to do the same.  It would mean
> that all the tools, like mknod(8) would not work with the new API.
> 
> Or am I misunderstanding your suggestion?

Yes :)

My suggestions is:

 - mknod for unprivilegued user is allowed in the following case

    (1) mount point is mounted with MNT_NODEV
    (2) mount point is owner by the user doing mknod

 - and maybe

    (3) we have a special mount option to allow it if we don't want
        to allow it for normal unprivilegued mounts for some reason

which implies we need to get in unprivilegued mounts first, but we'll
have to do that anyway.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/