linux-kernel - Re: [PATCH] kernel/printk.c: Concerns about the console handover

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Sep 2007 15:45:24 +0100
From:	Russell King <rmk+lkml@....linux.org.uk>
To:	"Maciej W. Rozycki" <macro@...ux-mips.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	Yinghai.Lu@....COM, bryan.wu@...log.com, dilinger@...ued.net,
	kraxel@...hat.com, lethal@...ux-sh.org, rgetz@...ckfin.uclinux.org,
	vapier.adi@...il.com
Subject: Re: [PATCH] kernel/printk.c: Concerns about the console handover

On Fri, Sep 21, 2007 at 03:36:05PM +0100, Maciej W. Rozycki wrote:
> On Fri, 21 Sep 2007, Russell King wrote:
> > You can find the fix in the mbox archive:
> > 
> >  http://ftp.arm.linux.org.uk/pub/linux/arm/kernel/git-cut/arm:devel.mbox
> 
>  Hmm, nothing of relevance there.

Hmm, it does help to occasionally run the script which uploads the
patches and stuff.  Also I typoed the URL:

 http://ftp.arm.linux.org.uk/pub/linux/arm/kernel/git-cur/arm:devel.mbox

>  I see no problem with implementing the ->pm() call as something like:
> 
> void zs_pm(struct uart_port uport, unsigned int state, unsigned int oldstate)
> {
> 	struct zs_port *zport = to_zport(uport);
> 
> 	if (state < 3)
> 		zport->regs[5] |= TxENAB;
> 	else
> 		zport->regs[5] &= ~TxENAB;
> 	write_zsreg(zport, R5, zport->regs[5]);
> }
> 
> itself, but it looks more like a workaround than a fix to me.  I'll have 
> to think about it and also double-check it is safe.  The SCC is about as 
> complicated as you can get with a serial port.

You will need the serial patch from the above mbox.

PS, Gerd's bouncing email address removed from the CC line.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/