linux-kernel - Re: [PATCH] Reduce __print_symbol/sprint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46F3E79B.7030305@grupopie.com>
Date:	Fri, 21 Sep 2007 16:47:39 +0100
From:	Paulo Marques <pmarques@...popie.com>
To:	Steven Rostedt <rostedt@...dmis.org>
CC:	Satyam Sharma <satyam@...radead.org>,
	Gilboa Davara <gilboad@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Reduce __print_symbol/sprint_symbol stack usage.

Steven Rostedt wrote:
> On Wed, Sep 19, 2007 at 03:25:15PM +0100, Paulo Marques wrote:
>> if we change the interface from "print_symbol(fmt, addr)" to 
>> "print_symbol(prefix, addr, int newline)" we can simply do:
>>
>> printk(prefix);
>> printk_symbol(addr);
>> if (newline)
>> 	printk("\n");
> 
> NACK
> 
> I just wrote something that does "print_symbol(" %s)\n", addr);"
> Notice the ")" in the output.

We can just change that to "print_symbol(prefix, addr, suffix)" instead. 
The concept is basically the same (and I wasn't very fond of that 
newline argument either).

As an added bonus we stop needing an extra layer to check that the 
string passed is in the right format with a single "%s" in it.

-- 
Paulo Marques - www.grupopie.com

"Very funny Scotty. Now beam up my clothes."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/