linux-kernel - Re: [PATCH] Re: Serial USB-driver for Winchiphead CH340/41 chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Sep 2007 09:18:50 -0700
From:	Greg KH <greg@...ah.com>
To:	Werner Cornelius <Werner.Cornelius@...nelius-consult.de>
Cc:	linux-kernel@...r.kernel.org, mtosatti@...hat.com
Subject: Re: [PATCH] Re: Serial USB-driver for Winchiphead CH340/41 chip

On Fri, Sep 21, 2007 at 10:15:11AM +0200, Werner Cornelius wrote:
> Hello,
> 
> attached you will find the patch against the 2.6.23-rc6-mm1
> 
> Changed fetaures:
> 
> 1. All baudrates possible (dynamic baudfactor calculation)
> 2. Added support of modem control and status lines.

You forgot:
	3. broke all formatting

:(

Please redo the patch such that the formating of the file is not changed
(you converted tabs to spaces).

> --- linux-2.6.23-rc6-mm1/drivers/usb/serial/ch341.c	2007-09-21 
> 09:56:56.000000000 +0200
> +++ develop/drivers/usb/serial/ch341.c	2007-09-21 10:00:26.000000000 +0200
> @@ -1,5 +1,9 @@
>  /*
> - * Copyright 2007, Frank A Kingswood <frank@...gswood-consulting.co.uk>
> + * Copyright 2007, Frank A Kingswood <frank <at> kingswood-consulting.co.uk>

Why did you change this email address?

> + *
> + * Copyright 2007, Werner Cornelius <werner <at> cornelius-consult.de>
> + * for changes/extenions regarding universal baud rate capability and modem
> + * line control/status routines. 

Don't put changelog information in a copyright notice, that's not
needed.  Just put your name there please, with a "real" email address.

And we need a "Signed-off-by:" line.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/