linux-kernel - Re: Fix printk levels in intel-rng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ada7imjy8sn.fsf@cisco.com>
Date:	Fri, 21 Sep 2007 15:04:40 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Dave Jones <davej@...hat.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: Fix printk levels in intel-rng

 > [   41.250634] intel_rng: Firmware space is locked read-only. <4>intel_rng: If you can't or
 > [   41.250638]  don't want to <4>intel_rng: disable this in firmware setup, and <4>intel_rng: if
 > [   41.250639]  you are certain that your <4>intel_rng: system has a functional
 > [   41.250641]  RNG, try<4>intel_rng: using the 'no_fwh_detect' option.
 > [   41.250706] agpgart: AGP aperture is 128M @ 0xe8000000

 >  			KERN_WARNING PFX "Firmware space is locked read-only. If you can't or\n"
 > -			KERN_WARNING PFX "don't want to disable this in firmware setup, and if\n"
 > -			KERN_WARNING PFX "you are certain that your system has a functional\n"
 > -			KERN_WARNING PFX "RNG, try using the 'no_fwh_detect' option.\n";
 > +			PFX "don't want to disable this in firmware setup, and if\n"
 > +			PFX "you are certain that your system has a functional\n"
 > +			PFX "RNG, try using the 'no_fwh_detect' option.\n";

I think Alan already fixed this in f3dc8c18 -- notice that your
screwed-up message has the <4> after eg read-only, and the current
code doesn't line-wrap there.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/