[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20070921223248.EA24D13DCD@wotan.suse.de>
Date: Sat, 22 Sep 2007 00:32:48 +0200 (CEST)
From: Andi Kleen <ak@...e.de>
To: major@...nvz.org, patches@...-64.org, linux-kernel@...r.kernel.org
Subject: [PATCH] [48/50] x86_64: return correct error code from child_rip in x86_64 entry.S
From: Andrey Mirkin <major@...nvz.org>
Right now register edi is just cleared before calling do_exit.
That is wrong because correct return value will be ignored.
Value from rax should be copied to rdi instead of clearing edi.
AK: changed to 32bit move because it's strictly an int
Signed-off-by: Andrey Mirkin <major@...nvz.org>
Signed-off-by: Andi Kleen <ak@...e.de>
-----
---
arch/x86_64/kernel/entry.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/arch/x86_64/kernel/entry.S
===================================================================
--- linux.orig/arch/x86_64/kernel/entry.S
+++ linux/arch/x86_64/kernel/entry.S
@@ -989,7 +989,7 @@ child_rip:
movq %rsi, %rdi
call *%rax
# exit
- xorl %edi, %edi
+ mov %eax, %edi
call do_exit
CFI_ENDPROC
ENDPROC(child_rip)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists