linux-kernel - Re: Unfortunate infinite make recursion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 22 Sep 2007 22:52:16 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Jan Engelhardt <jengelh@...putergmbh.de>
Cc:	zippel@...ux-m68k.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Unfortunate infinite make recursion

On Sat, Sep 22, 2007 at 01:24:32PM +0200, Jan Engelhardt wrote:
> Hi,
> 
> 
> You can cause a recursion in kbuild/make with the following:
> 
> make O=$PWD kernel/time.o
> make mrproper
> 
> Of course no one would use O=$PWD (that's just the testcase),
> but this happened too often:
> 
> /ws/linux/linux-2.6.23$ make O=/ws/linux/linux-2.6.23 kernel/time.o
> (Oops - should have been O=/ws/linux/obj-2.6.23!)
> 
> The make O=$PWD truncates the Makefile, making it necessary to run `git 
> checkout Makefile` - should you have git; or reextract the tarball 
> (should you /still/ have it). Well, can we catch this case somehow?

Does the following patch fix it at your end?
Seems to work for me.

	Sam

diff --git a/Makefile b/Makefile
index 6708e41..f787b05 100644
--- a/Makefile
+++ b/Makefile
@@ -115,7 +115,9 @@ saved-output := $(KBUILD_OUTPUT)
 KBUILD_OUTPUT := $(shell cd $(KBUILD_OUTPUT) && /bin/pwd)
 $(if $(KBUILD_OUTPUT),, \
      $(error output directory "$(saved-output)" does not exist))
-
+# Check the OUTPUT directory is not the same as where we have kernel src
+$(if $(filter-out $(KBUILD_OUTPUT),$(shell /bin/pwd)),, \
+     $(error Output directory (O=...) specify kernel src dir))
 PHONY += $(MAKECMDGOALS)
 
 $(filter-out _all,$(MAKECMDGOALS)) _all:

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/