linux-kernel - Re: [PATCH 5/5] Add fair "control groups" scheduler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070924095815.9d5f7f32.randy.dunlap@oracle.com>
Date:	Mon, 24 Sep 2007 09:58:15 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	vatsa@...ux.vnet.ibm.com
Cc:	akpm@...ux-foundation.org, Ingo Molnar <mingo@...e.hu>,
	dmitry.adamushko@...il.com, linux-kernel@...r.kernel.org,
	dhaval@...ux.vnet.ibm.com, containers@...ts.osdl.org,
	kamezawa.hiroyu@...fujitsu.com, menage@...gle.com, efault@....de
Subject: Re: [PATCH 5/5] Add fair "control groups" scheduler

On Mon, 24 Sep 2007 22:11:59 +0530 Srivatsa Vaddagiri wrote:

>  include/linux/cgroup_subsys.h |    6 ++
>  init/Kconfig                  |   24 +++++---
>  kernel/sched.c                |  122 ++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 145 insertions(+), 7 deletions(-)
> 
> Index: current/init/Kconfig
> ===================================================================
> --- current.orig/init/Kconfig
> +++ current/init/Kconfig
> @@ -327,13 +327,6 @@ config FAIR_GROUP_SCHED
>  	  This feature lets cpu scheduler recognize task groups and control cpu
>  	  bandwidth allocation to such task groups.
>  
> -config RESOURCE_COUNTERS
> -	bool "Resource counters"
> -	help
> -	  This option enables controller independent resource accounting
> -          infrastructure that works with cgroups
> -	depends on CGROUPS
> -
>  choice
>  	depends on FAIR_GROUP_SCHED
>  	prompt "Basis for grouping tasks"
> @@ -345,8 +338,25 @@ choice
>   		  This option will choose userid as the basis for grouping
>  		  tasks, thus providing equal cpu bandwidth to each user.
>  
> +	config FAIR_CGROUP_SCHED
> +		bool "Control groups"
> +		depends on CGROUPS
> +		help
> +		   This option allows you to create arbitrary task groups
> +		   using the "cgroup" psuedo filesystem and control
> +		   the cpu bandwidth allocated to each such task group.
> +		   Refer to Documentation/cgroups.txt for more information
> +		   on "cgroup" psuedo filesystem.

Too much indentation.

s/cpu/CPU/g please.

> +
>  endchoice
>  
> +config RESOURCE_COUNTERS
> +	bool "Resource counters"
> +	help
> +	  This option enables controller independent resource accounting
> +          infrastructure that works with cgroups

Use tab + 2 spaces to indent help text.


> +	depends on CGROUPS
> +
>  config SYSFS_DEPRECATED
>  	bool "Create deprecated sysfs files"
>  	default y


---
~Randy
Phaedrus says that Quality is about caring.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/