lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070924190917.GG8127@redhat.com>
Date:	Mon, 24 Sep 2007 15:09:17 -0400
From:	Dave Jones <davej@...hat.com>
To:	Jonathan Campbell <jon@...dgrounds.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Patches for tiny 386 kernels, again. Linux kernel
	2.6.22.7

On Mon, Sep 24, 2007 at 01:51:17AM -0700, Jonathan Campbell wrote:


 > +#if defined(__i386__) && defined(CONFIG_DMI)
 >  	dmi_check_system(acpi_dmi_table);
 >  #endif
 >  
 > +#ifdef CONFIG_DMI
 >  	dmi_scan_machine();
 > +#endif
 >  
 > +#ifdef CONFIG_DMI
 >  	/* Check and install the TSC clocksource */
 >  	dmi_check_system(bad_tsc_dmi_table);
 > +#endif
 >  
 > +#ifdef CONFIG_DMI
 >  	dmi_check_system(acpi_osl_dmi_table);
 > +#endif
 
Instead of adding all these ifdefs, we could just define
add something along the lines of..

#ifndef CONFIG_DMI
#define dmi_check_system do {} while (0)
#endif

in some header, which hides the uglies away from the code
whilst having the same net effect.

	Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ