linux-kernel - Re: [patch 1/2] Enable link power management for ata drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0709241624460.24423@alien.or.mcafeemobile.com>
Date:	Mon, 24 Sep 2007 16:28:49 -0700 (PDT)
From:	Davide Libenzi <davidel@...ilserver.org>
To:	roel <12o3l@...cali.nl>
cc:	Kristen Carlson Accardi <kristen.c.accardi@...el.com>,
	jgarzik@...ox.com, linux-ide@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	axboe@...nel.dk, Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [patch 1/2] Enable link power management for ata drivers

On Tue, 25 Sep 2007, roel wrote:

> > +	if (!(ap->flags & ATA_FLAG_IPM) || !ata_dev_enabled(dev)) {
> 
> 	if (!((ap->flags & ATA_FLAG_IPM) && ata_dev_enabled(dev))) {

int foo(int i, int j) {
        
        return !(i & 8) || !j;
}

int moo(int i, int j) {
        
        return !((i & 8) && j);
}


gcc -O2 -S:


.globl foo
        .type   foo, @function
foo:
        shrl    $3, %edi
        xorl    $1, %edi
        testl   %esi, %esi
        sete    %al
        orl     %eax, %edi
        andl    $1, %edi
        movl    %edi, %eax
        ret
.globl moo
        .type   moo, @function
moo:
        shrl    $3, %edi
        xorl    $1, %edi
        testl   %esi, %esi
        sete    %al
        orl     %eax, %edi
        andl    $1, %edi
        movl    %edi, %eax
        ret



- Davide


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/