linux-kernel - Re: [patch 1/2] Enable link power management for ata drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46F84F96.9090402@tiscali.nl>
Date:	Tue, 25 Sep 2007 02:00:22 +0200
From:	roel <12o3l@...cali.nl>
To:	Davide Libenzi <davidel@...ilserver.org>
CC:	Kristen Carlson Accardi <kristen.c.accardi@...el.com>,
	jgarzik@...ox.com, linux-ide@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	axboe@...nel.dk, Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [patch 1/2] Enable link power management for ata drivers

Davide Libenzi wrote:
> On Tue, 25 Sep 2007, roel wrote:
> 
>>> +	if (!(ap->flags & ATA_FLAG_IPM) || !ata_dev_enabled(dev)) {
>> 	if (!((ap->flags & ATA_FLAG_IPM) && ata_dev_enabled(dev))) {
> 
> int foo(int i, int j) {
>         
>         return !(i & 8) || !j;
> }
> 
> int moo(int i, int j) {
>         
>         return !((i & 8) && j);
> }
> 
> 
> gcc -O2 -S:
> 
> 
> .globl foo
>         .type   foo, @function
> foo:
>         shrl    $3, %edi
>         xorl    $1, %edi
>         testl   %esi, %esi
>         sete    %al
>         orl     %eax, %edi
>         andl    $1, %edi
>         movl    %edi, %eax
>         ret
> .globl moo
>         .type   moo, @function
> moo:
>         shrl    $3, %edi
>         xorl    $1, %edi
>         testl   %esi, %esi
>         sete    %al
>         orl     %eax, %edi
>         andl    $1, %edi
>         movl    %edi, %eax
>         ret

Indeed, no difference, except for the eye. 

do you not consider it an improvement or do you not want to change it?
or
don't you consider it an improvement and want to change it?

Never mind. Disregard if you please.

> - Davide

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/