linux-kernel - Re: [PATCH 1/3] Fix coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5E8967F2-474C-4019-AA9D-9C3601376DBD@mac.com>
Date:	Tue, 25 Sep 2007 16:47:19 -0400
From:	Kyle Moffett <mrmacman_g4@....com>
To:	Ingo Oeser <ioe-lkml@...eria.de>
Cc:	vatsa@...ux.vnet.ibm.com, Ingo Molnar <mingo@...e.hu>,
	linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Mike Galbraith <efault@....de>,
	Dhaval Giani <dhaval@...ux.vnet.ibm.com>,
	Dmitry Adamushko <dmitry.adamushko@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	randy.dunlap@...cle.com
Subject: Re: [PATCH 1/3] Fix coding style

On Sep 25, 2007, at 15:16:20, Ingo Oeser wrote:
> On Tuesday 25 September 2007, Srivatsa Vaddagiri wrote:
>> @@ -297,7 +293,7 @@ static int __init init_sched_debug_procf
>>  	pe->proc_fops = &sched_debug_fops;
>>
>>  #ifdef CONFIG_FAIR_USER_SCHED
>> -	pe = create_proc_entry("root_user_share", 0644, NULL);
>> +	pe = create_proc_entry("root_user_cpu_share", 0644, NULL);
>>  	if (!pe)
>>  		return -ENOMEM;
>
> What about moving this debug stuff under debugfs?  Please consider  
> using the functions in <linux/debugfs.h>.  They compile into  
> nothing, if DEBUGFS is not compiled in and have already useful  
> functions for reading/writing integers and booleans.

Umm, that's not a debugging thing.  It appears to be a tunable  
allowing you to configure what percentage of the total CPU that UID 0  
gets which is likely to be useful to configure on production systems;  
at least until better group-scheduling tools are produced.

Cheers,
Kyle Moffett

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/