linux-kernel - Re: [PATCH 05/25] Unionfs: cast page->index loff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070926083121.GA8421@infradead.org>
Date:	Wed, 26 Sep 2007 09:31:21 +0100
From:	Christoph Hellwig <hch@...radead.org>
To:	Erez Zadok <ezk@...sunysb.edu>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, viro@....linux.org.uk,
	hch@...radead.org
Subject: Re: [PATCH 05/25] Unionfs: cast page->index loff_t before shifting

On Tue, Sep 25, 2007 at 11:09:44PM -0400, Erez Zadok wrote:
> Fixes bugs in number promotion/demotion computation, as per
> <http://lkml.org/lkml/2007/9/20/17>

It's better to use te page_offset helper as that avoids any confusion
on where to cast.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/