linux-kernel - Re: 2.6.23-rc8-mm1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070926122856.GA10088@shadowen.org>
Date:	Wed, 26 Sep 2007 13:28:56 +0100
From:	Andy Whitcroft <apw@...dowen.org>
To:	Badari Pulavarty <pbadari@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	lkml <linux-kernel@...r.kernel.org>
Subject: Re: 2.6.23-rc8-mm1

On Tue, Sep 25, 2007 at 03:05:53PM -0700, Badari Pulavarty wrote:
> Hi Andy,
> 
> One the patch you created in -mm is causing compile warning.
> Here is the fix. Please verify.
> 
> Thanks,
> Badari
> 
> arch/powerpc/mm/init_64.c: In function `vmemmap_populated':
> arch/powerpc/mm/init_64.c:211: warning: passing arg 1 of `vmemmap_section_start' makes pointer from integer without a cast
> 
> vmemmap_section_start() gets called with an argument which is unsigned long.
> 
> Signed-off-by: Badari Pulavarty <pbadari@...ibm.com>

Clearly correct.  

Acked-by: Andy Whitcroft <apw@...dowen.org>

> Index: linux-2.6.23-rc8/arch/powerpc/mm/init_64.c
> ===================================================================
> --- linux-2.6.23-rc8.orig/arch/powerpc/mm/init_64.c	2007-09-25 09:18:13.000000000 -0700
> +++ linux-2.6.23-rc8/arch/powerpc/mm/init_64.c	2007-09-25 14:50:44.000000000 -0700
> @@ -189,10 +189,9 @@ void pgtable_cache_init(void)
>   * do this by hand as the proffered address may not be correctly aligned.
>   * Subtraction of non-aligned pointers produces undefined results.
>   */
> -unsigned long __meminit vmemmap_section_start(struct page *page)
> +unsigned long __meminit vmemmap_section_start(unsigned long page)
>  {
> -	unsigned long offset = ((unsigned long)page) -
> -						((unsigned long)(vmemmap));
> +	unsigned long offset = page - ((unsigned long)(vmemmap));
>  
>  	/* Return the pfn of the start of the section. */
>  	return (offset / sizeof(struct page)) & PAGE_SECTION_MASK;

-apw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/