linux-kernel - Re: [PATCH] usbvision-video: buggered method tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1190811745.5076.4.camel@gaivota>
Date:	Wed, 26 Sep 2007 10:02:25 -0300
From:	Mauro Carvalho Chehab <mchehab@...radead.org>
To:	Al Viro <viro@....linux.org.uk>
Cc:	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	Thierry MERLE <thierry.merle@...e.fr>
Subject: Re: [PATCH] usbvision-video: buggered method tables


Em Qua, 2007-09-26 às 01:53 +0100, Al Viro escreveu:
> duplicated .mmap in one, .vidioc_s_audio misspelled as .vidioc_g_audio
> in other
> 
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>

Acked-by: Mauro Carvalho Chehab <mchehab@...radead.org>

> ---
>  drivers/media/video/usbvision/usbvision-video.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/video/usbvision/usbvision-video.c b/drivers/media/video/usbvision/usbvision-video.c
> index e3371f9..0cb006f 100644
> --- a/drivers/media/video/usbvision/usbvision-video.c
> +++ b/drivers/media/video/usbvision/usbvision-video.c
> @@ -1387,7 +1387,6 @@ static const struct file_operations usbvision_fops = {
>  	.ioctl		= video_ioctl2,
>  	.llseek		= no_llseek,
>  /* 	.poll          = video_poll, */
> -	.mmap	       = usbvision_v4l2_mmap,
>  	.compat_ioctl  = v4l_compat_ioctl32,
>  };
>  static struct video_device usbvision_video_template = {
> @@ -1413,7 +1412,7 @@ static struct video_device usbvision_video_template = {
>  	.vidioc_s_input       = vidioc_s_input,
>  	.vidioc_queryctrl     = vidioc_queryctrl,
>  	.vidioc_g_audio       = vidioc_g_audio,
> -	.vidioc_g_audio       = vidioc_s_audio,
> +	.vidioc_s_audio       = vidioc_s_audio,
>  	.vidioc_g_ctrl        = vidioc_g_ctrl,
>  	.vidioc_s_ctrl        = vidioc_s_ctrl,
>  	.vidioc_streamon      = vidioc_streamon,
> @@ -1459,7 +1458,7 @@ static struct video_device usbvision_radio_template=
>  	.vidioc_s_input       = vidioc_s_input,
>  	.vidioc_queryctrl     = vidioc_queryctrl,
>  	.vidioc_g_audio       = vidioc_g_audio,
> -	.vidioc_g_audio       = vidioc_s_audio,
> +	.vidioc_s_audio       = vidioc_s_audio,
>  	.vidioc_g_ctrl        = vidioc_g_ctrl,
>  	.vidioc_s_ctrl        = vidioc_s_ctrl,
>  	.vidioc_g_tuner       = vidioc_g_tuner,
-- 
Cheers,
Mauro

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/