linux-kernel - Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46FA86DE.70204@garzik.org>
Date:	Wed, 26 Sep 2007 12:20:46 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	Peer Chen <peerchen@...il.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	akpm <akpm@...ux-foundation.org>,
	linux-ide <linux-ide@...r.kernel.org>
Subject: Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR

Alan Cox wrote:
> On Wed, 26 Sep 2007 10:33:28 -0400
> Jeff Garzik <jeff@...zik.org> wrote:
> 
>> Alan Cox wrote:
>>>>> NAK - mmio is an iomap so writel and readl are the wrong things to use
>>>> The patch is consistent with the rest of the driver.
>>>> You are welcome to submit a patch to convert ahci to using ioremap.
>>> You could just flip the relevant function to use ioread while you are
>>> tidying it up, instead of spreading new bugs into the code.
>> No, as I just noted above, the proper fix for this driver is to use 
>> ioremap rather than pci_iomap.
>>
>> Adding support to ahci for legacy PIO is completely pointless.
> 
> iomap isn't just for legacy PIO. It allows us to handle future weird
> mappings in ways ioremap cannot.

Well, when needs dictate, we can re-evaluate.

Until some future date arrives where it matters for all these MMIO-only 
drivers and hardware, it's just a bunch of pointless overhead for ahci 
and many other drivers.  It's also just not the Linux way to punish 
everybody for some edge case that so far only exists in email conversations.

The beauty of libata is that you don't have to enforce such a pogrom 
across all libata drivers.  The libata high level API is completely free 
from ioread/iowrite junk, leaving each driver to make its own decision.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/