linux-kernel - Re: [PATCH 2/6] LBS: fix uninitialized swapper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0709261926060.8443@blonde.wat.veritas.com>
Date:	Wed, 26 Sep 2007 19:34:29 +0100 (BST)
From:	Hugh Dickins <hugh@...itas.com>
To:	Christoph Lameter <clameter@....com>
cc:	Peter Zijlstra <peterz@...radead.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/6] LBS: fix uninitialized swapper_space

On Mon, 24 Sep 2007, Christoph Lameter wrote:
> On Fri, 21 Sep 2007, Hugh Dickins wrote:
> 
> > Swapping crashed immediately: must initialize new fields of swapper_space.
> 
> Thanks for finding that. It may be better though to use the new
> mapping_setup() function instead? That way there is no #ifdef.

Probably better, yes.  In -mm Peter is doing an #ifdef CONFIG_SWAP
bdi_init() on swapper_space.  Would make sense to do both together,
perhaps move them to a swapper_space_init() in swap_state.c, saving
his #ifdef too.  I suggest leave such cleanups until one or the
other is mainlined.

Hugh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/