linux-kernel - Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c0942db0709261243h1267140br70796c7fcfb165e3@mail.gmail.com>
Date:	Wed, 26 Sep 2007 12:43:08 -0700
From:	"Ray Lee" <ray-lk@...rabbit.org>
To:	"Brett Warden" <brett.warden@...il.com>
Cc:	linux-kernel@...r.kernel.org, trivial@...nel.org
Subject: Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

On 9/26/07, Brett Warden <brett.warden@...il.com> wrote:
> Appeases the warning "parport0 (bw-qcam): use data_reverse for this!"
>
> Signed-off-by: Brett T. Warden <brett.warden@...il.com>
>
> ---
>
> It seems to work fine with my Quickcam under 2.6.22.

> @@ -369,7 +374,11 @@ static void qc_reset(struct qcam_device *q)
>                         break;
>
>                 case QC_ANY:
> -                       write_lpcontrol(q, 0x20);
> +                       /*
> +                        * Replaced with reverse_port
> +                        * write_lpcontrol(q, 0x20);
> +                        */
> +                       reverse_port(q);
>                         write_lpdata(q, 0x75);
>
>                         if (read_lpdata(q) != 0x75) {

Just as an aside, if you've tested this and it works, then there's no
point to keep the write_lpcontrol even as a comment. Kill those four
lines, and if someone's interested in what happened they'll just look
at the file history.

Ray
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/