linux-kernel - Re: [PATCH 13/25] Unionfs: add un/likely conditionals on dir ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46FAD1D2.8030306@tiscali.nl>
Date:	Wed, 26 Sep 2007 23:40:34 +0200
From:	roel <12o3l@...cali.nl>
To:	Erez Zadok <ezk@...sunysb.edu>
CC:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, viro@....linux.org.uk,
	hch@...radead.org
Subject: Re: [PATCH 13/25] Unionfs: add un/likely conditionals on dir ops

Erez Zadok wrote:

> @@ -194,7 +194,7 @@ int check_empty(struct dentry *dentry, struct unionfs_dir_state **namelist)
>  
>  	BUG_ON(!S_ISDIR(dentry->d_inode->i_mode));
>  
> -	if ((err = unionfs_partial_lookup(dentry)))
> +	if (unlikely((err = unionfs_partial_lookup(dentry))))
>  		goto out;
>  
>  	bstart = dbstart(dentry);

Is it bad to leave this assignment within the unlikely()?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/