linux-kernel - [PATCH] usb_serial: Stop passing NULL to functions that expect data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070926230840.231df58e@the-village.bc.nu>
Date:	Wed, 26 Sep 2007 23:08:40 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	akpm@...l.org, linux-kernel@...r.kernel.org, greg@...ah.com
Subject: [PATCH] usb_serial: Stop passing NULL to functions that expect data

Earlier patches have removed the checking for old v new differences from
the USB drivers so we can now pass in a valid blank old termios so that
we don't to fill the drivers with magic hacks for console support

Signed-off-by: Alan Cox <alan@...hat.com>

diff -u --new-file --exclude-from /usr/src/exclude --recursive linux.vanilla-2.6.23rc8-mm1/drivers/serial/serial_core.c linux-2.6.23rc8-mm1/drivers/serial/serial_core.c
--- linux.vanilla-2.6.23rc8-mm1/drivers/serial/serial_core.c	2007-09-26 16:46:54.000000000 +0100
+++ linux-2.6.23rc8-mm1/drivers/serial/serial_core.c	2007-09-18 16:28:20.000000000 +0100
@@ -1885,6 +1885,7 @@
 		 int baud, int parity, int bits, int flow)
 {
 	struct ktermios termios;
+	static struct ktermios dummy;
 	int i;
 
 	/*
@@ -1930,7 +1931,7 @@
 	 */
 	port->mctrl |= TIOCM_DTR;
 
-	port->ops->set_termios(port, &termios, NULL);
+	port->ops->set_termios(port, &termios, &dummy);
 	co->cflag = termios.c_cflag;
 
 	return 0;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/