lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <46FB2ACD.6030107@oracle.com>
Date:	Wed, 26 Sep 2007 21:00:13 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Ram Dorai <deathtofat@...il.com>
CC:	Konrad Rzeszutek <konrad@...nok.org>, linux-kernel@...r.kernel.org,
	pjones@...hat.com, konradr@...hat.com, konradr@...ux.vnet.ibm.com
Subject: Re: [PATCH] Add iSCSI iBFT support.

Ram Dorai wrote:
> 
>     Fixed.
>      > > +static int
>      > > +ibft_mmap_binary(struct kobject *kobj, struct bin_attribute
>     *attr,
>      > > +            struct vm_area_struct *vma)
>      >
> 
> 
> 
> Do we not put a space between binary and '('. Is that against the coding 
> guidelines?

Right, we do not put a space there.

It's read_binary(ko, attr, vma);

so function names have no space following them, but
if, for, switch, and while do have space following them.

-- 
~Randy
Phaedrus says that Quality is about caring.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ