[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <46FB563A.80108@gmail.com>
Date: Thu, 27 Sep 2007 16:05:30 +0900
From: Tejun Heo <htejun@...il.com>
To: Mark Lord <liml@....ca>
CC: Andrew Morton <akpm@...ux-foundation.org>,
michal.k.k.piotrowski@...il.com, bryan@...ores.ca,
linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org,
Jeff Garzik <jgarzik@...ox.com>
Subject: Re: Stardom SATA HSM violation
Mark Lord wrote:
> Tejun Heo wrote:
>> Hello,
>>
>> Mark Lord wrote:
>>> I reported a very similar bug back a few releases ago.
>>> Anyone who wants to try it themselves, can do this with hdparm-7.7 (from
>>> sourceforge):
>>>
>>> hdparm --drq-hsm-error /dev/sda
>>>
>>> Whether or not it hangs the machine does depend upon exactly which SATA
>>> LLD is used,
>>> and what model/revision of drive is installed. But if it hangs for you
>>> (eg. Tejun),
>>> then you now have a way to reproduce a HSM error "on demand" for
>>> testing. :)
>>
>> Neat. Is this the FIFO-draining issue?
>
> Yeah, that's the one. And I still patch my own kernels to
> automatically drain up to 512 words from the FIFO when this happens.
>
> Works like a charm. Patch below for demonstration purposes.
>
> Signed-Off-By: Mark Lord <mlord@...ox.com>
I think there have been enough cases where this draining was necessary.
IIRC, ata_piix was involved in those cases, right? If so, can you
please submit a patch which applies this only to affected controllers?
I don't feel too confident about applying this to all SFF controllers.
Thanks.
--
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists