linux-kernel - Re: [RFC][PATCH] make reiserfs stop using 'struct file' for internal xattr operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070927210423.GA6117@infradead.org>
Date:	Thu, 27 Sep 2007 22:04:23 +0100
From:	Christoph Hellwig <hch@...radead.org>
To:	Dave Hansen <haveblue@...ibm.com>
Cc:	Christoph Hellwig <hch@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Laurent Riffard <laurent.riffard@...e.fr>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	reiserfs-devel@...r.kernel.org
Subject: Re: [RFC][PATCH] make reiserfs stop using 'struct file' for internal xattr operations

On Thu, Sep 27, 2007 at 01:53:39PM -0700, Dave Hansen wrote:
> -int reiserfs_commit_write(struct file *f, struct page *page,
> -			  unsigned from, unsigned to);
> -int reiserfs_prepare_write(struct file *f, struct page *page,
> -			   unsigned from, unsigned to);
> +int reiserfs_commit_write(struct page *page, unsigned from, unsigned to);
> +int reiserfs_prepare_write(struct page *page, unsigned from, unsigned to);

I doubt this will work.  These are also used for the ->prepare_write
and ->commit_write aops, and the method signature definitively wants
a file there, even if it's zero..

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/