linux-kernel - Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070927222934.010f1898@the-village.bc.nu>
Date:	Thu, 27 Sep 2007 22:29:34 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	"Brett Warden" <brett.warden@...il.com>
Cc:	"Ray Lee" <ray-lk@...rabbit.org>,
	"Randy Dunlap" <randy.dunlap@...cle.com>,
	linux-kernel@...r.kernel.org, trivial@...nel.org
Subject: Re: [PATCH] bw-qcam: use data_reverse instead of manually poking
 the control register

On Thu, 27 Sep 2007 12:28:31 -0700
"Brett Warden" <brett.warden@...il.com> wrote:

> Fixes use of parport_write_control() to match the newer interface that
> requires explicit parport_data_reverse() and parport_data_forward()
> calls. This eliminates the following error message and restores the
> original intended behavior:

Looks good

> parport0 (bw-qcam): use data_reverse for this!
> 
> Also increases threshold in qc_detect() from 300 to 400, as my camera
> often results in a count of approx 330. Added a kernel error message
> to indicate detection failure.

Likewise

> Signed-off-by: Brett T. Warden <brett.warden@...il.com>

Acked-by: Alan Cox <alan@...hat.com>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/