linux-kernel - Re: 2.6.23-rc8-mm1 -- powerpc link failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070927151317.67cac358.akpm@linux-foundation.org>
Date:	Thu, 27 Sep 2007 15:13:17 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	apw@...dowen.org, vagabon.xyz@...il.com,
	linux-kernel@...r.kernel.org, kamalesh@...ux.vnet.ibm.com
Subject: Re: 2.6.23-rc8-mm1 -- powerpc link failure

On Thu, 27 Sep 2007 14:13:21 +0200 (CEST)
Jiri Kosina <jkosina@...e.cz> wrote:

> i386 and x86_64: randomize brk()
> 
> ...
>
> --- a/arch/x86_64/ia32/ia32_binfmt.c
> +++ b/arch/x86_64/ia32/ia32_binfmt.c
> @@ -262,6 +262,7 @@ static void elf32_init(struct pt_regs *);
>  #define ARCH_HAS_SETUP_ADDITIONAL_PAGES 1
>  #define arch_setup_additional_pages syscall32_setup_pages
>  extern int syscall32_setup_pages(struct linux_binprm *, int exstack);
> +extern void arch_randomize_brk(void);
>  
>  #include "../../../fs/binfmt_elf.c" 

Is this sinful extern-decl-in-C acually needed?
 
> index b4fbe47..5a1adf9 100644
> --- a/include/asm-x86_64/elf.h
> +++ b/include/asm-x86_64/elf.h
> @@ -177,4 +177,6 @@ do if (vdso_enabled) {						\
>  
>  #endif
>  
> +extern void arch_randomize_brk(void);
> +
>  #endif

Because we already have a declaration in the correct place?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/