linux-kernel - Re: [RFC] QoS params patch update.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070928000847.GA30814@linux-sh.org>
Date:	Fri, 28 Sep 2007 09:08:47 +0900
From:	Paul Mundt <lethal@...ux-sh.org>
To:	Mark Gross <mgross@...ux.intel.com>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>,
	linux-pm <linux-pm@...ts.linux-foundation.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [RFC] QoS params patch update.

On Thu, Sep 27, 2007 at 01:17:39PM -0700, Mark Gross wrote:
> Updated qos PM parameter patch:
> Note: the replacing of latency.c with this is a separate patch.
> 
> this patch attempts to address the issues raised so far.
> 
[snip]

> +static int register_new_qos_misc(struct qos_object *qos)
> +{
> +	int ret;
> +
> +	qos->qos_power_miscdev.minor = MISC_DYNAMIC_MINOR;
> +	qos->qos_power_miscdev.name = qos->name;
> +	qos->qos_power_miscdev.fops = &qos_power_fops;
> +
> +	ret = misc_register(&qos->qos_power_miscdev);
> +
> +	return ret;
> +}
> +
Minor nit, ret is a pointless variable here, you can just return
misc_register directly.

Other than that, this looks much better!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/