[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20070928020132.f6c6f528.akpm@linux-foundation.org>
Date: Fri, 28 Sep 2007 02:01:32 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Ingo Molnar <mingo@...e.hu>
Cc: Andy Whitcroft <apw@...dowen.org>,
Randy Dunlap <rdunlap@...otime.net>,
Joel Schopp <jschopp@...tin.ibm.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] update checkpatch.pl to version 0.10
On Fri, 28 Sep 2007 10:40:03 +0200 Ingo Molnar <mingo@...e.hu> wrote:
> i ran it over kernel/sched.c and there are many bogus warnings that i
> reported to you earlier:
>
> WARNING: multiple assignments should be avoided
> #2319:
> + max_load = this_load = total_load = total_pwr = 0;
That warning is non-bogus, although this is one of the bogosities which
I personally don't bother fixing or making a fuss about.
But I do think it detracts from the readability of the code, and from
patches which later alter that code. A bit.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists