linux-kernel - Re: [RFC] New kernel-message logging API (take 2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 28 Sep 2007 11:45:18 +0200 (CEST)
From:	Jan Engelhardt <jengelh@...putergmbh.de>
To:	Vegard Nossum <vegard.nossum@...il.com>
cc:	LKML <linux-kernel@...r.kernel.org>,
	Kyle Moffett <mrmacman_g4@....com>,
	Michael Holzheu <holzheu@...ux.vnet.ibm.com>,
	Joe Perches <joe@...ches.com>, Rob Landley <rob@...dley.net>,
	Dick Streefland <dick.streefland@...ium.nl>,
	Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com>,
	Jesse Barnes <jesse.barnes@...el.com>,
	Arnd Bergmann <arnd@...db.de>,
	Emil Medve <Emilian.Medve@...escale.com>,
	Stephen Hemminger <shemminger@...ux-foundation.org>,
	"linux@...izon.com" <linux@...izon.com>
Subject: Re: [RFC] New kernel-message logging API (take 2)

On Sep 27 2007 23:18, Vegard Nossum wrote:
>  * kprint_<level>() is better than kprint(<level), ) because in the
>    case of the default log-level, the argument can be omitted.
>  * Memory allocated for entries and arguments is done in a ring-buffer
>    with variable-sized chunks. Arguments are chained with a singly-
>    linked list.
>  * Use SUBSYSTEM and KBUILD_MODNAME
>  * Rename kprint buffers to kprint blocks

This is overall, quite a lot. I suggest one-thing-at-a-time,
starting with kprint_<level>() that is compiled out if desired
and no fancy block or newline stuff.

_Then_, will see how it flies. All of this smells like a bit of
overdesigning, aka http://en.wikipedia.org/wiki/YAGNI
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/