linux-kernel - Re: [PATCH 1/4] dma: add dma_flags_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070928002019.GK30013@sgi.com>
Date:	Thu, 27 Sep 2007 17:20:19 -0700
From:	akepner@....com
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Grant Grundler <grundler@...isc-linux.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Jes Sorensen <jes@....com>, David Miller <davem@...emloft.net>,
	Roland Dreier <rdreier@...co.com>,
	linux-kernel@...r.kernel.org, jejb <james.bottomley@...eleye.com>
Subject: Re: [PATCH 1/4] dma: add dma_flags_set_dmaflush() to dma interface

On Tue, Sep 25, 2007 at 10:13:33PM -0700, Randy Dunlap wrote:
> On Tue, 25 Sep 2007 17:00:57 -0700 akepner@....com wrote:
> ......
> 1.  Function signature should be on one line if possible (and it is).
> Aw crud, I looked at dma-mapping.h and it uses this format sometimes.
> Well, it's undesirable, so please don't propagate it.
> 
> 2.  No parens on return: it's not a function.
> 
> static inline int dma_flags_set_dmaflush(int dir)
> {
> 	return dir;
> }
> 
> 
> Similar comments for patch 2/4: sn-ia64.
> 

Both fixed in next version. Thanks, Randy.

-- 
Arthur

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/